Push 2025 11 13#986
Merged
Merged
Conversation
The IPv4 binding code was incorrectly wrapped in #ifdef _WIN32, causing the server to fall through to IPv6 binding even when IPv4 was explicitly requested with the -4 flag on Linux systems. This fix removes the Windows- specific conditional around the IPv4 binding logic while keeping platform- specific socket close calls. Fixes the issue where pcm-sensor-server with -4 flag would fail to accept connections from curl and wget on Linux. Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
Change-Id: I0dc2e4cedc1205fc3f8dba17e6126ea39cec915a
opcm
approved these changes
Nov 13, 2025
ogbrugge
approved these changes
Nov 13, 2025
Contributor
ogbrugge
left a comment
ogbrugge
left a comment
There was a problem hiding this comment.
I love the new copilot commit messages ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.